-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uphold /capabilities
endpoint spec changed — need to adjust get_capabilities
#23849
Comments
Does this need a separate Android implementation? |
No, the desktop change will take care of it on Android, too. |
The above will require |
Verification PASSED on
Case 1 - Sufficient capabilities - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 2 - Insufficient capabilities, receives=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 3 - Insufficient capabilities, receives=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 4 - Insufficient capabilities, sends=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 5 - Insufficient capabilities, sends=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 6 - Insufficient capabilities, receives=1 with requirements, sends=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 7 - Insufficient capabilities, receives=2, sends=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
|
For Android, I'd recommend testing Case 1, 2, 4 from #23849 (comment). Spot checking 3, 5, 6, 7 if there's time will be sufficient. |
Verification in progress on Samsung Galaxy S21 using Brave Note - while running the below tests you may encounter known issue #16376 on the brave://rewards-internals page. Case 1 - Sufficient capabilities - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 2 - Insufficient capabilities, receives=1 with requirements - IN PROGRESS |
Verification PASSED on
Case 3 - Insufficient capabilities, receives=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 4 - Insufficient capabilities, sends=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 2 - Insufficient capabilities, receives=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
|
Description
Due to a specification change of Uphold's
/capabilities
endpoint, users that are required to provide information to Uphold (e.g. CDD, EDD, etc.) are now allowed to verify with Uphold, although they cannot send (tip), and/or receive (monthly payouts).Miscellaneous Information:
cc: @Miyayes @brave/rewards-client
The text was updated successfully, but these errors were encountered: