Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt non-GET requests from the query filter #26377

Closed
fmarier opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#15706
Closed

Exempt non-GET requests from the query filter #26377

fmarier opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#15706

Comments

@fmarier
Copy link
Member

fmarier commented Oct 28, 2022

Bounce trackers and email newsletter trackers use GET requests (typically redirect chains of them). We can therefore exempt POST requests, which are typically the result of form submissions and a user action. This should help mitigate any webcompat issues arising from filtering parameters that a form might need in order to work properly.

This is also in line with the Mozilla policy on URL decorations.

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.39 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.47.39
  2. launched Brave
  3. loaded https://fmarier.github.io/brave-testing/query-filter.html
  4. scrolled down to the POSTS tests section
  5. clicked on the button
  6. examined the URL bar

Confirmed the URL I ended up on included the ?fbclid=1234 query-string parameter: https://fmarier.org/query-filter/?fbclid=1234

test page result
Screen Shot 2022-11-02 at 4 27 53 PM Screen Shot 2022-11-02 at 4 28 01 PM

@antonok-edm
Copy link
Collaborator

AdGuard's removeparam option applies to GET, HEAD, and OPTIONS. I haven't checked the behavior, but uBO's wiki links to the same document for reference. We should do the same.

https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#removeparam
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#removeparam

@fmarier
Copy link
Member Author

fmarier commented Nov 17, 2022

@antonok-edm HEAD and OPTIONS to be added in #26827.

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave 1.47.167 Chromium: 109.0.5414.80 (Official Build) (64-bit)
Revision 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{https://github.com/brave/brave-browser/issues/1178}
OS Android 12; Build/SP1A.210812.016
  1. installed 1.47.x
  2. launched Brave
  3. loaded https://fmarier.github.io/brave-testing/query-filter.html
  4. scrolled down to the POSTS tests section
  5. clicked on the button
  6. examined the URL bar

Confirmed the URL I ended up on included the ?fbclid=1234 query-string parameter: https://fmarier.org/query-filter/?fbclid=1234

Example Example
screenshot-1673305157249 screenshot-1673305215410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants