-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when re-opening Brave News Customize 2.0 UI after following sources #26876
Comments
Saw this also using
Backtrace: 94190400-483e-2b09-0000-000000000000 |
Interestingly, this seems to be caused by a suggestion for a non-existing publisher... |
Verified
|
Brave | 1.47.110 Chromium: 108.0.5359.71 (Official Build) beta (x86_64) |
---|---|
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016} |
OS | macOS Version 13.1 (Build 22C5059b) |
Steps:
- installed
1.47.110
- launched Brave
- opened a new-tab page
- clicked
Customize
- clicked on
Brave News
in theCustomize
dashboard - clicked
Turn on Brave News
- clicked
Follow
onThe New York Times
in thePopular
category - clicked
X
to close the modal - clicked
Brave News
in theCustomize
dashboard again
Confirmed no crash, and was able to subscribe to the New York TImes
feed
example |
example |
example |
---|---|---|
![]() |
![]() |
![]() |
Verification passed on
Verified test plan from the description Verified no crash |
Labelling as |
The above requires |
Verification passed on
Verified test plan from the description Verified no crash |
Verified
|
Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (x86_64) |
---|---|
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9} |
OS | macOS Version 13.1 (Build 22C65) |
Steps:
- installed
1.46.141
- launched Brave
- opened a new-tab page
- scrolled down
- opted in to Brave News
- clicked on
Customize
- clicked on
Brave News
- clicked
Follow
onCNN
- reopened the
Customize Brave News
dialog
Confirmed no crash when opening the Brave News
dialog after following a source
example | example | example | example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Verification PASSED on
Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 10 Version 21H2 (Build 19044.2251)
Steps:
- installed
1.46.141
- launched Brave
- opened a new-tab page
- scrolled down
- opted in to Brave News
- clicked on
Customize
- clicked on
Brave News
- clicked
Follow
onCNN
- reopened the
Customize Brave News
dialog
Confirmed no crash when opening the Brave News
dialog after following a source
example | example | example | example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Follow some sources then re-open Brave News Customize 2.0 UI. Crash.
Reproduced on 1.46.110 and 1.47.85. Reproduced on Linux and Windows
Steps to Reproduce
Note: Make sure Brave News Customize 2.0 UI is enabled
Customize
Brave News
in theCustomize Dashboard
Turn on
Brave News`Follow
onThe New York Times
in thePopular
categoryX
to close the modalBrave News
in theCustomize Dashboard
aagainActual result:
Crash
Expected result:
No crash
Reproduces how often:
100% repro rate
Brave version (brave://version info)
Version/Channel Information:
cc @fallaciousreasoning @petemill @mattmcalister @brave/qa-team
The text was updated successfully, but these errors were encountered: