Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News Uplifts]: Fixes for 1.47.x #16221

Merged
merged 1 commit into from
Dec 8, 2022
Merged

[Brave News Uplifts]: Fixes for 1.47.x #16221

merged 1 commit into from
Dec 8, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Dec 4, 2022

Uplifts #16148 which fixes brave/brave-browser#27024

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner December 4, 2022 22:17
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 4, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

kjozwiak commented Dec 8, 2022

iOS failed due to [2022-12-05T23:10:48.830Z] iossim: ERROR: Unable to find a device iPhone 6s with SDK 16.1 which was already fixed via #16230. However, the above doesn't affect/touch iOS so no need to rebase the issue. Other platforms passed without any issues/failures.

@kjozwiak kjozwiak added this to the 1.47.x - Beta milestone Dec 8, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16148 (comment).

@kjozwiak kjozwiak merged commit 63b274e into 1.47.x Dec 8, 2022
@kjozwiak kjozwiak deleted the bn-uplift-1.47 branch December 8, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants