Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 109.0.5414.74 to Chromium 109.0.5414.80 #27658

Closed
emerick opened this issue Jan 5, 2023 · 8 comments · Fixed by brave/brave-core#16539
Closed

Upgrade from Chromium 109.0.5414.74 to Chromium 109.0.5414.80 #27658

emerick opened this issue Jan 5, 2023 · 8 comments · Fixed by brave/brave-core#16539

Comments

@emerick
Copy link
Contributor

emerick commented Jan 5, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/109.0.5414.74..109.0.5414.80?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2023

The above requires 1.47.165 or higher for 1.47.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2023

Affected areas checked/verified:

Remaining work for the above:

  • Win x64 - simple spot check to ensure that 109.0.5414.80 hasn't caused any obvious regressions
  • Android ARM - simple spot check to ensure that 109.0.5414.80 hasn't caused any obvious regressions
  • Linux - simple spot check to ensure that 109.0.5414.80 hasn't caused any obvious regressions
  • Android Tablet - simple spot check to ensure that 109.0.5414.80 hasn't caused any obvious regressions
  • macOS x64 - complete affected areas

@LaurenWags
Copy link
Member

LaurenWags commented Jan 6, 2023

Verification in progress with

Brave | 1.47.165 Chromium: 109.0.5414.80 (Official Build) (x86_64)
-- | --
Revision | 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS | macOS Version 12.6.2 (Build 21G320)

Partial verification completed under #27638 (comment) as noted in #27658 (comment).

Remaining verifications are below:

2. Changing settings on the following works

NTP background - PASSED

  • Confirmed enabling/disabling of Show Background Images toggle works as expected for
    - User your own
    - Brave backgrounds
    - Solid colors
    - Gradients
    - Show Sponsored Images
  • Confirmed enabling/disabling of Show Sponsored Images toggle works as expected while Show Background Images is enabled
  • Confirmed enabling/disabling of Refresh on every new tab toggle works as expected for
    - Upload from devices
    - Solid colors
    - Gradients
ex1 ex2 ex3 ex4 ex5
1 2 3 4 5

Shields- PASSED

  • Confirmed site specific shield settings are working as expected
  • Confirmed Global shield settings are working as expected
  • Confirmed number of blocked items are shown correctly on a opened sites when the shields is ON
  • Confirmed number of blocked items are NOT shown on shield when the shields is OFF
  • Confirmed number of blocked items aren't shown when shields Show the number... in settings is toggled OFF
  • Confirmed scripts blocking is working as expected
  • Confirmed shield settings can be changed after the upgrade
ex1 ex2 ex3
Screen Shot 2023-01-06 at 9 50 06 AM Screen Shot 2023-01-06 at 9 50 18 AM Screen Shot 2023-01-06 at 9 50 30 AM

Permission expiration - PASSED

  • Confirmed permission expiration work as expected when selected Allow
    • until I close this site
    • for 24 hours
    • for 1 week
    • forever
  • Reset permission works as expected
  • Verified that the Block forever button correctly sets the value for Location in brave://settings/content to Block
  • Verified that the Allow button sets the value for Location in brave://settings/content to Allow
  • Verified that the site permission link at the bottom of the dialog links to brave://settings/content
ex1 ex2 ex3 ex4 ex5
1 2 3 4 5

Note, location permission was the primary test for above using browserleaks.com/geo. Notification permission was also spot checked, primarily using sites like https://pushalert.co/demo and https://cleverpush.com/en/test-notifications/.

Adding/removing items to/from playlist - PASSED

Used below C109 Nightly as Playlist is not available on 1.47.x RC:

Brave | 1.48.112 Chromium: 109.0.5414.61 (Official Build) nightly (x86_64)
-- | --
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | macOS Version 12.6.2 (Build 21G320)

-Confirmed able to add and remove items to/from playlist

ex1 ex2
Screen Shot 2023-01-09 at 11 51 21 AM Screen Shot 2023-01-09 at 11 51 32 AM
3. MacOS: upgrade detection from prior to 109, upgrade from 109 to newer 109 - PASSED
  1. Upgrade from prior to 109 (1.46.x with C108 to 1.47.x with C109) - PASSED
  • Installed 1.46.153 Chromium: 108.0.5359.128 (Official Build) (x86_64)
  • Close/relaunch to pull griffin
  • After relaunch, navigated to brave://settings/help
  • Confirmed an update was found and downloaded
  • Relaunched to get update
  • Updated to 1.47.167 Chromium: 109.0.5414.80 (Official Build) (x86_64)
1.46.153 1.47.167
Screen Shot 2023-01-09 at 12 22 47 PM Screen Shot 2023-01-09 at 12 23 02 PM
  1. Upgrade from 109 to same 109 (1.47.x with C109 to 1.47.x with C109) - PASSED
  • Installed 1.47.165 Chromium: 109.0.5414.80 (Official Build) (x86_64)
  • Close/relaunch to pull griffin
  • After relaunch, navigated to brave://settings/help
  • Confirmed an update was found and downloaded
  • Relaunched to get update
  • Updated to 1.47.167 Chromium: 109.0.5414.80 (Official Build) (x86_64)
1.47.165 1.47.167
Screen Shot 2023-01-09 at 12 28 53 PM Screen Shot 2023-01-09 at 12 29 16 PM
  1. Upgrade from older 109 to newer 109 (1.47.x with Chromium 109.0.5414.74 to 1.47.x with Chromium 109.0.5414.80) - PASSED
  • Installed 1.47.164 Chromium: 109.0.5414.74 (Official Build) (x86_64)
  • Close/relaunch to pull griffin
  • After relaunch, navigated to brave://settings/help
  • Confirmed an update was found and downloaded
  • Relaunched to get update
  • Updated to 1.47.167 Chromium: 109.0.5414.80 (Official Build) (x86_64)
1.47.164 1.47.167
Screen Shot 2023-01-09 at 12 33 46 PM Screen Shot 2023-01-09 at 12 34 00 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.47.165 Chromium: 109.0.5414.80 (Official Build) (64-bit)
-- | --
Revision | 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS | Windows 11 Version 21H2 (Build 22000.1335)

image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 6, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 6, 2023

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 on version:

Brave	1.47.165 Chromium: 109.0.5414.80 (Official Build) (64-bit) 
Revision	0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS	Android 12; Build/SP1A.210812.016
  • Version bump
  • Check Branding
  • Affected Areas
Example Example
screenshot-1673043393900 screenshot-1673043430381

@btlechowski
Copy link

btlechowski commented Jan 9, 2023

Verification passed on

Brave 1.47.167 Chromium: 109.0.5414.80 (Official Build) (64-bit)
Revision 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS Ubuntu 18.04 LTS

image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 9, 2023
@kjozwiak
Copy link
Member

Removing release-notes/include in favour of #27710. Leaving the QA/Yes label as all the work in this issue has been completed so no one will be working on this one rather than #27710.

@srirambv
Copy link
Contributor

USB/HID wallets can be used (access permission)
Verification passed on

Brave 1.47.168 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.963)
  • Verified able to connect Trezor/Ledger wallet and import accounts
  • Verified able to import Ethereum accounts from Ledger and Trezor
  • Verified able to import Solana accounts from Ledger
  • Verified able to import accounts from different derivation paths for Ethereum accounts
  • Verified ablet so approve or reject transactions form Ledger
  • Encountered #27726
Import Ledger Accounts Import Trezor Accounts Ledger Transactions
Ledger.Connect.mp4
Trezor.Connect.mp4
Ledger.Transaction.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment