-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave Panel always shows Brave Rewards is off
on corrupted profile
#3697
Comments
Reproduced on macOS
After joining Rewards on brave://rewards, panel displayed as expected. |
Reproduced on Linux
|
What is being asked here? The "wallet turned off" panel has been modified to present user with "Re enable Rewards". Do we want that? Do we want the first run enable panel? Do we want to attempt to fix the profile? |
@jasonrsadler problem here is that we think that rewards are disabled, when they are not actually turned on and you need to join in. So rewards page and panel should display the same state |
Removed comment Moved corrupt wallet check after state files load
Removed comment Moved corrupt wallet check after state files load Removed extension value
Removed comment Moved corrupt wallet check after state files load Removed extension value Addressing comments Run sanity check on panel open to check wallet state. lint
Removed comment Moved corrupt wallet check after state files load Removed extension value Addressing comments Run sanity check on panel open to check wallet state. lint
Verified passed with
Verification passed on
|
Follow up to #3046
Steps to Reproduce
Actual result:
Important: If I go to
brave://rewards
I can join the rewards throughYes, I am in
button.Expected result:
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @brave/legacy_qa @NejcZdovc
The text was updated successfully, but these errors were encountered: