Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Panel always shows Brave Rewards is off on corrupted profile #3697

Closed
btlechowski opened this issue Mar 13, 2019 · 5 comments · Fixed by brave/brave-core#2097
Closed

Comments

@btlechowski
Copy link

Follow up to #3046

Steps to Reproduce

  1. Use the staging profile https://github.com/brave/brave-browser/files/2823589/Brave-Browser-Beta-05925.zip
  2. Open Brave Panel

Actual result:

image

Important: If I go to brave://rewards I can join the rewards through Yes, I am in button.

Expected result:

image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.62.25 Chromium: 73.0.3683.67 (Official Build) beta (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

cc @brave/legacy_qa @NejcZdovc

@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 18, 2019
@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.62.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

After joining Rewards on brave://rewards, panel displayed as expected.

@GeetaSarvadnya
Copy link

Reproduced on Linux

Brave 0.62.26 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

@jasonrsadler
Copy link

What is being asked here? The "wallet turned off" panel has been modified to present user with "Re enable Rewards". Do we want that? Do we want the first run enable panel? Do we want to attempt to fix the profile?

@NejcZdovc
Copy link
Contributor

@jasonrsadler problem here is that we think that rewards are disabled, when they are not actually turned on and you need to join in. So rewards page and panel should display the same state

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Mar 27, 2019

Unverified

No user is associated with the committer email.
Removed comment

Moved corrupt wallet check after state files load
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 2, 2019

Unverified

No user is associated with the committer email.
Removed comment

Moved corrupt wallet check after state files load

Removed extension value
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 12, 2019

Unverified

No user is associated with the committer email.
Removed comment

Moved corrupt wallet check after state files load

Removed extension value

Addressing comments

Run sanity check on panel open to check wallet state.

lint
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 13, 2019

Unverified

No user is associated with the committer email.
Removed comment

Moved corrupt wallet check after state files load

Removed extension value

Addressing comments

Run sanity check on panel open to check wallet state.

lint
@jasonrsadler jasonrsadler added this to the 0.65.x - Nightly milestone Apr 15, 2019
@LaurenWags
Copy link
Member

LaurenWags commented May 20, 2019

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.111 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment