Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask Leo in URL search bar is hidden under Bottom toolbar when SE is set to Google #40217

Closed
3 of 6 tasks
hffvld opened this issue Aug 2, 2024 · 1 comment · Fixed by brave/brave-core#26591
Closed
3 of 6 tasks
Assignees
Labels
browser-ai bug OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include

Comments

@hffvld
Copy link
Contributor

hffvld commented Aug 2, 2024

Description

Ask Leo in the URL search bar is hidden under Bottom toolbar when SE is set to Google. This can happen with other search engines if many results are pulled for a query.

Steps to reproduce

  1. Launch Brave
  2. Go to Settings > Appearance
  3. Set Enable bottom toolbar to ON
  4. Go back to Settings > Search engines
  5. Set to Google > Close Settings
  6. Tap in the URL search bar > Type car
  7. Close the onscreen keyboard > Observe

Actual result

Ask Leo in the URL search bar is hidden under Bottom toolbar when SE is set to Google. This can happen with other search engines if many results are pulled for a query.


1 2
1 2

Expected result

Ask Leo in the URL search bar must be visible when the Bottom toolbar is ON or OFF.


1 2
1 2

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.69.129
Chromium: 127.0.6533.73 (Official Build) beta (64-bit)

Device

  • Brand/Model: ANY PHONE
  • Android version: ANY

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@hffvld hffvld added bug QA/Yes OS/Android Fixes related to Android browser functionality browser-ai labels Aug 2, 2024
@hffvld hffvld added this to Browser AI Aug 2, 2024
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 2, 2024
@mattmcalister mattmcalister moved this to Todo in Browser AI Aug 2, 2024
@mattmcalister mattmcalister added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Browser AI Nov 15, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 15, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 10, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Dec 10, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 BP11.241025.006 release-keys
Brave build: 1.75.83 
Chromium: 132.0.6834.33 (Official Build) canary (64-bit) 

STEPS:

  1. Follow the STR/TP from Ask Leo in URL search bar is hidden under Bottom toolbar when SE is set to Google #40217 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Ask Leo in the URL search bar is visible for a query.
  • Verified the same for bottom an top toolbar.

1 2
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai bug OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants