Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Portfolio Price History by Default #44512

Closed
Douglashdaniel opened this issue Mar 7, 2025 · 3 comments · Fixed by brave/brave-core#28029
Closed

Hide Portfolio Price History by Default #44512

Douglashdaniel opened this issue Mar 7, 2025 · 3 comments · Fixed by brave/brave-core#28029
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.76.x - Release #5

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Mar 7, 2025 •
edited
Loading

Platforms

Windows, macOS, Linux, Android

Description

To save on API usage and Portfolio real-estate we should hide the Portfolio price history by default.

  • Ensure that Price History is not being fetched when Price History is hidden
  • Make Price History hidden by default, user will still be able to unhide the graph in wallet settings.

Image
@Douglashdaniel Douglashdaniel added feature-request feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include labels Mar 7, 2025
@Douglashdaniel Douglashdaniel self-assigned this Mar 7, 2025
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 7, 2025
@Douglashdaniel Douglashdaniel mentioned this issue Mar 7, 2025
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 7, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 10, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 10, 2025
This was referenced Mar 12, 2025
Merged
Merged
@kjozwiak kjozwiak added the OS/Android Fixes related to Android browser functionality label Mar 12, 2025
@kjozwiak
Copy link
Member

The above requires 1.76.77 or higher for 1.76.x verification 👍 Added OS/Android as it was mentioned as one of the platforms via #44512 (comment).

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.76.78 Chromium: 134.0.6998.95 (Official Build) (64-bit)
Revision bb8bd4b63ffb95bd9b413ab372e80beb17357a8b
OS Windows 11 Version 24H2 (Build 26100.3194)
  • Verified steps from brave/brave-core#28029
  • Verified adding BRAVE_WALLET_DEBUG=true shows console logs
  • Verified when graph is disabled, there are no entries for priceHistory requests
  • Verified when graph is enabled, console logs entries for priceHistory requests
44512.mp4

@srirambv srirambv mentioned this issue Mar 17, 2025
Closed
6 tasks
@srirambv
Copy link
Contributor

Verification passed on Google PIxel 8 with Android 15 running 1.76.78 x64 build

Clean Install Wallet Restore
Image Image

@LaurenWags LaurenWags mentioned this issue Mar 20, 2025
Closed
@hffvld hffvld mentioned this issue Mar 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Status: Done
Milestone
1.76.x - Release #5
Development

Successfully merging a pull request may close this issue.

fix(wallet): Hide Portfolio Price History Graph by Default brave/brave-core
4 participants
@kjozwiak @srirambv @Douglashdaniel @brave-builds