Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chromium 69.0.3497.12 #656

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Upgrade to Chromium 69.0.3497.12 #656

merged 3 commits into from
Jul 31, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 29, 2018 •
edited
Loading

Fix #293
Needs: brave/brave-core#297

All unit and browser tests pass in debug mode.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

CC @petemill

@bbondy bbondy self-assigned this Jul 29, 2018
@bbondy bbondy requested a review from yrliou July 29, 2018 15:18
bbondy
bbondy commented Jul 29, 2018
View reviewed changes
package.json Outdated
@@ -37,7 +37,7 @@
},
"brave-core": {
"dir": "src/brave",
"branch": "master",
"branch": "69.0.3497.12",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before landing, I'll put this back to master.

@bbondy bbondy mentioned this pull request Jul 29, 2018
Merged
9 tasks
yrliou
yrliou previously approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit 1532e51 into master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou left review comments

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @yrliou