Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 80.0.3987.132 to Chromium 80.0.3987.149 (1.7.x). #8744

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

mkarolin
Copy link
Contributor

Fixes #8728
Related PR: brave/brave-core#4981

Uplift from: #8729

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Sorry, something went wrong.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
Upgrade from Chromium 80.0.3987.132 to Chromium 80.0.3987.149.
@kjozwiak
Copy link
Member

Looks like the only failure was on macOS due to Publish xUnit test failing for test-unit and test-browser which is a known intermittent issue that's not related to this PR hence not blocking uplift.

@kjozwiak kjozwiak requested a review from a team March 18, 2020 18:01
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. As per #8744 (comment), all the failures are known issues and not blocking. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit b04eba9 into 1.7.x Mar 18, 2020
@kjozwiak kjozwiak deleted the 80.0.3987.149-1.7.x branch March 18, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants