Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android crash blockchaintoken (uplift to 1.38.x) #12737

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Android crash blockchaintoken (uplift to 1.38.x) #12737

merged 1 commit into from
Mar 24, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 24, 2022 •
edited by kjozwiak
Loading

Uplift of #12735
Resolves brave/brave-browser#21857

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team March 24, 2022 17:13
@brave-builds brave-builds self-assigned this Mar 24, 2022
@brave-builds brave-builds added this to the 1.38.x - Beta milestone Mar 24, 2022
@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 24, 2022
@kjozwiak
Copy link
Member

Looks like Win x64 failed both BraveClearDataOnExitTwoBrowsersTest.OneOTR & RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted. However, these are known as per brave/brave-browser#21126 & brave/brave-browser#21809. Either way, CI/skip-windows was added and the fix is Android specific so there's no need to restart Win.

kjozwiak
kjozwiak approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12735 (comment).

@kjozwiak kjozwiak merged commit 3e737fa into 1.38.x Mar 24, 2022
@kjozwiak kjozwiak deleted the pr12735_android_crash_blockchaintoken_1.38.x branch March 24, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @SergeyZhukovsky @brave-browser-releases