Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set brave wallet string state synchronously. (uplift to 1.37.x) #12803

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Set brave wallet string state synchronously. (uplift to 1.37.x) #12803

merged 1 commit into from
Apr 5, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 29, 2022 •
edited by kjozwiak
Loading

Uplift of #12748
Resolves brave/brave-browser#21809

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner March 29, 2022 10:06
@brave-builds brave-builds requested review from emerick, deeppandya and a team and removed request for a team March 29, 2022 10:06
@brave-builds brave-builds self-assigned this Mar 29, 2022
@brave-builds brave-builds added this to the 1.37.x - Release milestone Mar 29, 2022
@kjozwiak kjozwiak mentioned this pull request Apr 1, 2022
Merged
7 tasks
kjozwiak
kjozwiak approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved 👍 QA has verified the PR on Nightly as per #12748 (comment).

@kjozwiak kjozwiak merged commit 7035653 into 1.37.x Apr 5, 2022
@kjozwiak kjozwiak deleted the pr12748_issues/21809_1.37.x branch April 5, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@emerick emerick Awaiting requested review from emerick emerick is a code owner automatically assigned from brave/rewards-client

@deeppandya deeppandya Awaiting requested review from deeppandya deeppandya is a code owner automatically assigned from brave/rewards-client

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.37.x - Release #5
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases