Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 103 to Chromium 104. #13498

Merged
merged 128 commits into from
Jul 22, 2022
Merged

Upgrade from Chromium 103 to Chromium 104. #13498

merged 128 commits into from
Jul 22, 2022

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented May 26, 2022

Fixes brave/brave-browser#23092
Fixes brave/brave-browser#22922

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels May 26, 2022
@cdesouza-chromium cdesouza-chromium force-pushed the cr104 branch 11 times, most recently from 5f4ba9c to 7c4eca4 Compare June 1, 2022 19:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

mkarolin and others added 21 commits July 22, 2022 13:33
All/GetAuthTokenFunctionEnleGranularPermisableGranularPermissionsTest.Enabsions/*
Chromium change:
https://chromium.googlesource.com/chromium/src/+/359d072ae95c50bf630c5b3c1537ba1421bb1a76

commit 359d072ae95c50bf630c5b3c1537ba1421bb1a76
Author: Moe Ahmadi <mahmadi@chromium.org>
Date:   Mon May 16 23:17:33 2022 +0000

    [RQ] Adds feature, params, and about:flags entry for repeatable queries

    Bug: 1317829
Chromium change:
https://chromium.googlesource.com/chromium/src/+/0c85c0795b4830a77add242eb54ee7ba36ea5a0f

commit 0c85c0795b4830a77add242eb54ee7ba36ea5a0f
Author: Andy Paicu <andypaicu@chromium.org>
Date:   Mon Jul 11 10:53:15 2022 +0000

    Avoid using |delegate_| after the PermissionPromptBubbleView constructor.

    When a tab is closed and WebContents is destroyed, a permission prompt bubble view will be finalized asynchronously. That can lead to a situation, where the view calls into freed WebContents.

    More details: https://docs.google.com/document/d/1Ou320Q_O6iEVTI-EnhVzcSgheYwZ7tFow5mH2kA0-ZY/edit?resourcekey=0-2f8-Wmg-8avrewv1Om7MFA#heading=h.6qqfv5apsb0k

    Bug: 1329814
WebSocketBrowserTestWithAllowFileAccessFromFiles.CheckFileOrigin

This test occasionally fails on X86 on CI.
In Debug build the Settings WebUI is blank with an error loading
//resources/polymer/v3_0/iron-dropdown/iron-dropdown.js

This error happens because our
brave/browser/resources/settings/brave_wallet_page/add_wallet_network_dialog.js
uses cr_searchable_drop_down.js element that we add to the build by
patching ui/webui/resources/cr_elements/BUILD.gn to include
cr_searchable_drop_down/cr_searchable_drop_down.ts, which is normally
only built for ChromeOS.

However, cr_searchable_drop_down/cr_searchable_drop_down.ts imports
//resources/polymer/v3_0/iron-dropdown/iron-dropdown.js, which is not
included in the build because it too normally is only built for
ChromeOS. We have to apply similar patching here.
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin merged commit 6579488 into master Jul 22, 2022
@mkarolin mkarolin deleted the cr104 branch July 22, 2022 17:32
@mkarolin mkarolin added this to the 1.43.x - Nightly milestone Jul 22, 2022
mkarolin added a commit that referenced this pull request Jul 23, 2022
Upgrade from Chromium 103 to Chromium 104.
mkarolin added a commit that referenced this pull request Jul 25, 2022
Upgrade from Chromium 103 to Chromium 104.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet