-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News] Fix direct feeds and favicon sizes #15713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Storybook has been deployed to preview UI for the latest push |
simonhong
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ it would be great to have a test case for ShouldDisplayFeedItem()
changes.
A Storybook has been deployed to preview UI for the latest push |
Verified
|
Brave | 1.47.36 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64) |
---|---|
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
OS | macOS Version 11.7.1 (Build 20G918) |
brave/brave-browser#26368:
- install
1.47.36
- launch Brave
- set
brave://flags/#brave-news-v2
toEnabled
- set
brave://flags/#brave-news-subscribe-button
toEnabled
- click
Relaunch
- open a new-tab page
- scroll down
- click on
Show Brave News
- click on
Customize
- type
common
underDiscover
- click on
Follow
- compare the favicon to the larger one in Sources
Confirmed favicons are now right-sized

brave/brave-browser#26339:
- install
1.47.36
- launch Brave
- open a new-tab page
- click on
Customize
- click on
Brave News
- type
https://www.rt.com/rss-feed/
into Feed URL - click
Add source
- close the dialog
- scroll down
- click on
Show Brave News
- scroll more
- confirmed I saw an `RT.com - Daily news article
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- scrolled a lot
- looked for
RT.com - Daily news
Confirmed both the RT.com source as well as the previously-viewed (in News v1) article is still present
example | example | example | example | example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
fallaciousreasoning
added a commit
that referenced
this pull request
Nov 1, 2022
kjozwiak
added a commit
that referenced
this pull request
Nov 3, 2022
[Uplift] [Brave News] Fix direct feeds and favicon sizes (#15713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26368
Resolves brave/brave-browser#26339
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: