Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): handle nullable reward in eth_feeHistory #19481

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

onyb
Copy link
Member

@onyb onyb commented Jul 29, 2023

Resolves brave/brave-browser#31959

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Before After

@onyb onyb merged commit 56caf80 into master Jul 31, 2023
@onyb onyb deleted the h/wallet/nullable-reward-fee-history branch July 31, 2023 07:55
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 31, 2023
brave-builds added a commit that referenced this pull request Jul 31, 2023
brave-builds added a commit that referenced this pull request Jul 31, 2023
@srirambv
Copy link
Contributor

srirambv commented Aug 1, 2023

Verification passed on

Brave 1.58.62 Chromium: 116.0.5845.51 (Official Build) nightly (64-bit)
Revision 8e87aa7
OS Linux
  • Verified steps from PR
  • Verified panel shows correct fee estimates
19481.mp4

kjozwiak pushed a commit that referenced this pull request Aug 1, 2023
kjozwiak pushed a commit that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with EIP-1559 fee estimation on zksync (part 2)
3 participants