Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ad-block DEPS for not wrongly blocking blob: URLs #196

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 27, 2018

Fix brave/brave-browser#428
Which is this fix: brave-experiments/ad-block@fa3cd87

Auditors: @emerick

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy self-assigned this Jun 27, 2018
@emerick emerick self-requested a review June 27, 2018 15:56
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton
Copy link
Member

@bbondy should this be pulled into browser-laptop too?

@bbondy
Copy link
Member Author

bbondy commented Jun 27, 2018

Thanks for checking. No it's not needed @bsclifton because we only consider http and https URLs there.

@bbondy bbondy merged commit 5ba1feb into master Jun 27, 2018
@bsclifton bsclifton deleted the update-adblock-deps branch June 27, 2018 18:16
cezaraugusto pushed a commit that referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adblock breaks image upload on Twitter
3 participants