Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runs initMiscAndroidMetrics from an UI thread in case of connection failure (uplift to 1.62.x) #21311

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Runs initMiscAndroidMetrics from an UI thread in case of connection failure (uplift to 1.62.x) #21311

merged 2 commits into from
Dec 9, 2023
+44 −8

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 8, 2023 •
edited by kjozwiak
Loading

Uplift of #21171
Uplift of #21219
Resolves brave/brave-browser#34649
Resolves brave/brave-browser#34698

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner December 8, 2023 14:37
@brave-builds brave-builds self-assigned this Dec 8, 2023
@brave-builds brave-builds added this to the 1.62.x - Beta milestone Dec 8, 2023
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Dec 8, 2023
kjozwiak
kjozwiak approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍

@kjozwiak kjozwiak merged commit d6f8a4a into 1.62.x Dec 9, 2023
@kjozwiak kjozwiak deleted the pr21171_android_mojo_connection_error_handler_1.62.x branch December 9, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brave-builds @kjozwiak @SergeyZhukovsky