-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update short cut pin state properly on Windows #23254
Conversation
fix brave/brave-browser#26301 Polling the pinned state after asking to Windows because it's actually pinned when user allowed via os notification. We'll check 10 times with 2s interval after asking to Windows. If user doesn't react or disallowed within that time, we doesn't change the state.
8e583f0
to
d42b69c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
Verification
Case 1: New Install - Clicked
2024-04-30_16h48_41.mp4Case 2: New Install - Clicked
2024-04-30_16h54_37.mp4Case 3: New Profile - Clicked
2024-04-30_16h59_39.mp4Case 4: New Profile - Clicked
2024-04-30_17h02_57.mp4 |
Resolves brave/brave-browser#26301
Polling the pinned state after asking to Windows because it's actually pinned
when user allowed via os notification.
We'll check 10 times with 2s interval after asking to Windows.
If user doesn't react or disallowed within that time, we doesn't change the state.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Pin
button and click allow from os notification