Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in Private Tab #26316

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Fix typos in Private Tab #26316

merged 3 commits into from
Nov 14, 2024

Conversation

simoarpe
Copy link
Collaborator

@simoarpe simoarpe commented Oct 31, 2024

Resolves brave/brave-browser#41848

Screenshot 2024-10-31 at 12 29 52 PM

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@simoarpe simoarpe added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 31, 2024
@simoarpe simoarpe self-assigned this Oct 31, 2024
@simoarpe simoarpe requested a review from a team as a code owner October 31, 2024 11:22
@@ -1400,7 +1400,7 @@ Are you sure you want to do this?
Browsing visibility
</message>
<message name="IDS_BRAVE_NEW_TAB_PRIVATE_VISIBILITY_DESCRIPTION" desc="Browsing visibility description shown when a user opens a private tab explaining private mode">
Note that -even in private windows- your browsing activity may still be visible to your ISP, network observers, or your employer (if you're using a work device/network).
Note that - even in private windows - your browsing activity may still be visible to your ISP, network observers, or your employer (if you're using a work device/network).
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should use a double dash as well in that place instead of -, right @timchilds?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my understanding. cc our resident dash expert @rmcfadden3 to confirm.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official style is em dashes, no spaces. So:

Note that—even in private windows—your browsing activity…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the necessary adjustments to the text as requested. However, I would like to kindly mention that, although I understand the use of em dashes is grammatically correct in American English, as a non-native speaker, this style can be somewhat concerning. It has the potential to cause significant confusion for individuals whose primary language is not American English. Perhaps, a more universal and easily understood form could be achieved using commas instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @simoarpe , we will definitely have confusions after translation to other languages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @AndyAnds265 ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey all, sorry I missed this comment.

the localized side can be customized in the strings so unless something is hardcoded we should be able to edit by language

Copy link
Collaborator Author

@simoarpe simoarpe Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, wouldn't it be better to get rid of the dashes in favor of commas for all the languages?
Benefits:

  • More consistent style across all the languages
  • International users that keeps Brave in English (like myself) would find it easier to read. (In many languages dashes don't exist)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with commas for the reasons @simoarpe highlighted.

@simoarpe simoarpe added CI/skip-ios Do not run CI builds for iOS and removed CI/skip-android Do not run CI builds for Android labels Nov 1, 2024
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ from string reviewers based on comment from @timchilds #26316 (comment)

@simoarpe simoarpe merged commit fbacaab into master Nov 14, 2024
17 checks passed
@simoarpe simoarpe deleted the simone/fix-private-tab-typos branch November 14, 2024 11:48
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 14, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing space between a word and dash in the string Note that — even in private windows — your...
7 participants