Revert "[cr134][WIP] Fix TabDragController tab dragging calculation"

[simonhong]

This reverts commit 4d6e57f.

Revert reason: This change was added for handling https://chromium-review.googlesource.com/c/chromium/src/+/6160815 but it's reverted by https://chromium-review.googlesource.com/c/chromium/src/+/6234751

By reverting this, we could avoid invalid non_client_view() access that causes brave/brave-browser#44362.
Also can get proper dragged tab under cursor that fixes brave/brave-browser#44282

fix brave/brave-browser#44362
fix brave/brave-browser#44282

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

See the linked issue.

[brave-builds]

Released in v1.78.11

[cdesouza-chromium]

This change has broken cr135 as a lot of the functions being overridden don't exist anymore. https://chromium-review.googlesource.com/c/chromium/src/+/6160815

[bsclifton]

@cdesouza-chromium was the original change (https://chromium-review.googlesource.com/c/chromium/src/+/6160815) relanded upstream after being reverted in https://chromium-review.googlesource.com/c/chromium/src/+/6234751? If 135 already had a reland (and doesn't have the issue), this PR and SHA can probably be reverted from the cr135 branch

[LaurenWags]

Verified with

Brave | 1.78.11 Chromium: 134.0.6998.39 (Official Build) nightly (arm64)
-- | --
Revision | 8fd4caafca95b2f6ba91d1896df3a0c425cf8342
OS | macOS Version 15.4 (Build 24E5206s)

Case 1 - brave/brave-browser#44362

• Crash was difficult to repro, however OP @thypon reported it was resolved for him via https://bravesoftware.slack.com/archives/C7VLGSR55/p1741031895690229?thread_ts=1740936097.444129&cid=C7VLGSR55
• Per discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1741030030380149?thread_ts=1741001310.500659&cid=CHGKGMHDJ, did a quick spot check to confirm that drag/drop of vertical tabs was generally working as expected:
  • confirmed that dragging/dropping tabs within the same window still works
  • confirmed that detaching/adding a tab to a new window works without any issues
  • confirmed that detaching/adding a tab to its own window works. Note - encountered known issue Detached tab in new window is not rendered till releasing the mouse press brave-browser#44032

Screen.Recording.2025-03-03.at.4.20.44.PM.mov

Case 2 - brave/brave-browser#44282

Using 1.76.71 reproduced the mis-positioned mouse cursor:

Screen.Recording.2025-03-03.at.4.27.20.PM.mov

Using 1.78.11 saw that the mouse cursor is positioned properly (note, in certain cases you will encounter brave/brave-browser#44032):

Screen.Recording.2025-03-03.at.4.29.38.PM.mov