-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a crash in Brave News mojo channel creation #27951
Conversation
…ke sure to reconnect the mojo channel on UI thread only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Changes look good!
Released in v1.78.18 |
@SergeyZhukovsky can you pls uplift? |
@iefremov I would like to monitor how does it perform. The crash isn't a recent regression plus I don't see it at all in Google Play Console. I would prefer it migrates naturally. |
Moves Brave News mojo channel creation to a sequenced task runner. Make sure to reconnect the mojo channel on UI thread only.
Similar to how
MiscAndroidMetrics
crash was fixed in#21132
#21171
Resolves brave/brave-browser#39166
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: