Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash in Brave News mojo channel creation #27951

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Mar 4, 2025

Moves Brave News mojo channel creation to a sequenced task runner. Make sure to reconnect the mojo channel on UI thread only.
Similar to how MiscAndroidMetrics crash was fixed in
#21132
#21171

Resolves brave/brave-browser#39166

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…ke sure to reconnect the mojo channel on UI thread only
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Mar 4, 2025
@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 4, 2025
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@simoarpe simoarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changes look good!

@SergeyZhukovsky SergeyZhukovsky merged commit a9365fd into master Mar 4, 2025
19 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_news_mojo branch March 4, 2025 18:33
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 4, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.18

@iefremov
Copy link
Contributor

iefremov commented Mar 5, 2025

@SergeyZhukovsky can you pls uplift?

@SergeyZhukovsky
Copy link
Member Author

@iefremov I would like to monitor how does it perform. The crash isn't a recent regression plus I don't see it at all in Google Play Console. I would prefer it migrates naturally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in brave_news::BraveNewsController::MakeRemote
7 participants