[Android] Fix for search widget suggestions

[samartnik]

Removed obsolete check that blocked upstream's code execution.

Resolves brave/brave-browser#40610

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[SergeyZhukovsky]

++

[deeppandya]

LGTM

[brave-builds]

Released in v1.78.21

[hffvld]

Verified on Galaxy Z Fold 6 using version(s):

Device/OS: Galaxy Z Fold 6 / q6quew-user 14 UP1A.231005.007 release-keys
Brave build: 1.78.21 
Chromium: 134.0.6998.45 (Official Build) canary (64-bit) 

---

Show browser suggestions is ON

STEPS:

1. Fresh install and launch Brave
2. Hamburger menu > Settings > Search engines
3. Make sure Show browser suggestions, Show search suggestions and Show top sites suggestions are ON
4. Close Brave and add Search widget to a Home screen
5. Type a query in the search widget > Verify that suggested searches and websites are both shown
6. Open Brave > Hamburger menu > Settings > Search engines
7. Disable Show search suggestions
8. Go back to the widget > Type a query > Verify that only suggested websites are shown
9. Open Brave > Hamburger menu > Settings > Search engines
10. Enable Show search suggestions, but disable Show top sites suggestions
11. Go back to the widget > Type a query > Verify that only suggested searches are shown
12. Open Brave > Hamburger menu > Settings > Search engines
13. Disable both Show search suggestions and Show top sites suggestions
14. Go back to the widget > Type a query > Verify that no suggested searches or websites are shown

ACTUAL RESULTS:

• Verified that suggested searches and websites are both shown, if Show browser suggestions, Show search suggestions and Show top sites suggestions are ON.
• Verified that only suggested websites are shown, if Show browser suggestions and Show top sites suggestions are ON, but Show search suggestions is OFF.
• Verified that only suggested searches are shown, if Show browser suggestions and Show search suggestions are ON, but Show top sites suggestions is OFF.
• Verified that no suggested searches or websites are shown, if Show browser suggestions is ON, but Show search suggestions and Show top sites suggestions are OFF.

---

Suggested searches and websites are shown	Only Ssuggested websites are shown	Only Ssuggested searches are shown	Suggested searches and websites are NOT shown

Show browser suggestions is OFF

STEPS:

1. Fresh install and launch Brave
2. Hamburger menu > Settings > Search engines
3. Make sure Show browser suggestions, Show search suggestions and Show top sites suggestions are ON
4. Disable Showbrowser suggestions
5. Close Brave and add Search widget to a Home screen
6. Type a query in the search widget > Verify that no suggested searches or websites are shown. Observed that both things are shown actually
7. Open Brave > Hamburger menu > Settings > Search engines
8. Enable Show browser suggestions
9. Disable both Show search suggestions and Show top sites suggestions
10. Disable Show browser suggestions
11. Go back to the widget > Type a query > Verify that no suggested searches or websites are shown

ACTUAL RESULTS:

• Verified that no suggested searches or websites are shown, if Show browser suggestions, Show search suggestions and Show top sites suggestions are OFF.
• Observed that suggested searches and websites are both shown, if Show browser suggestions is OFF, but Show search suggestions and Show top sites suggestions are ON.

---

1	2	3	4	5

[Soren01]

Tested on version 1.78.21—the issue is gone! Thank you! – Poco X7 Pro (Android 15)