Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Leo on Android when a global JS toggle set to blocked #27978

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Mar 5, 2025

Resolves brave/brave-browser#36012

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Go to 3 dots menu->Settings->Site Settings->Javascript
  • Set the Javascript switch to off
  • Exit menu
  • Check that there is Ask Leo auto suggestion in the URL bar
  • There is Leo in the main menu
  • There is Leo in the 3 dots menu->Setttings

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Mar 5, 2025
@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 5, 2025
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SergeyZhukovsky SergeyZhukovsky merged commit ad3e776 into master Mar 5, 2025
19 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_enable_leo_when_js_off branch March 5, 2025 20:23
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 5, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leo breaks when disabling javascript
4 participants