Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Tab Organization with Leo #28103

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Implement Tab Organization with Leo #28103

wants to merge 3 commits into from
+2,563 −34

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 12, 2025

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@yrliou
Implement engine consumer and conversation api client for tab organiz…
bb6510a 
…ation feature

- GetSuggestedTopics, DedupeTopics, GetFocusTabs are implemented to get
  topics and classified tabs result from the server.
@yrliou yrliou self-assigned this Mar 12, 2025
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 12, 2025
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@yrliou
Implement Brave's own tab organization UI
3a8c8fd 
- Hook into where Chromium's tab organization UI is located by overriding
  auto_tab_groups_page to our own implementation.
- Chromium's TabSearchPageHandler and TabSearchUI is overriden to include what we
  need for our own tab organization feature using Leo.
- Add a pref toggle in Leo settings page for user to enable/disable tab
  organization UI.
- Add a feature flag for tab organization feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yrliou yrliou

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrliou @brave-builds