[cr135 follow up] Fixes duplicated Startpage search engine. #28293
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
approved these changes
Mar 24, 2025
The duplication can be seen in the search engine choice dialogs in the settings and in the search engine NTP widget customization. The duplication happens on upgrade from previous version (cr134) because in the prior version Startpage engine was saved in prefs with ID we created for it, but after the upgrade we were using the new ID that Chromium added. That merged the new engine and the old engine into the list. To fix we should continue to use our old ID for Startpage instead of switching to the Chromium's id for the engine.
mkarolin
force-pushed
the
maxk-fix-startpage-engine-dupe
branch
from
d5417c1 to
a02f9bb
Compare
24 tasks
mkarolin
added a commit
that referenced
this pull request
Mar 25, 2025
The duplication can be seen in the search engine choice dialogs in the settings and in the search engine NTP widget customization. The duplication happens on upgrade from previous version (cr134) because in the prior version Startpage engine was saved in prefs with ID we created for it, but after the upgrade we were using the new ID that Chromium added. That merged the new engine and the old engine into the list. To fix we should continue to use our old ID for Startpage instead of switching to the Chromium's id for the engine.
24 tasks
|
Released in v1.78.64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#44861