Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't inadvertently confuse pkg filename with promo code (uplift to 0.68.x) #2968

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Don't inadvertently confuse pkg filename with promo code (uplift to 0.68.x) #2968

merged 1 commit into from
Jul 23, 2019
+12 −8

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jul 22, 2019

Uplift of #2964

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Sorry, something went wrong.

@emerick emerick self-assigned this Jul 22, 2019
@emerick emerick added this to the 0.68.x - Dev milestone Jul 22, 2019
kjozwiak
kjozwiak approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.68.x approved after deliberating with @rebron. Please ensure that all the correct labels are added and that the appropriate issue is moved into the correct milestone.

@emerick emerick merged commit 507bb55 into 0.68.x Jul 23, 2019
@emerick emerick deleted the pr2964_fix-pkg-postinstall_0.68.x branch July 23, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

@bbondy bbondy

@bsclifton bsclifton

@rebron rebron

@srirambv srirambv

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emerick @kjozwiak