Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests to read endpoint data from test files #385

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Updated tests to read endpoint data from test files #385

merged 1 commit into from
Sep 4, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Sep 4, 2018 •
edited
Loading

Resolves brave/brave-browser#940

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Same as #375

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler self-assigned this Sep 4, 2018
@jasonrsadler jasonrsadler changed the title Updated tests to read endpoint data from test files wip - Updated tests to read endpoint data from test files Sep 4, 2018
@jasonrsadler jasonrsadler reopened this Sep 4, 2018
@jasonrsadler jasonrsadler changed the title wip - Updated tests to read endpoint data from test files Updated tests to read endpoint data from test files Sep 4, 2018
bbondy
bbondy approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner! Thanks.

@NejcZdovc NejcZdovc force-pushed the rewards branch 3 times, most recently from 3162763 to 75021f1 Compare September 4, 2018 08:21
NejcZdovc
NejcZdovc approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are working in debug

@NejcZdovc NejcZdovc merged commit aea26f1 into brave:rewards Sep 4, 2018
@jasonrsadler jasonrsadler deleted the file_test_data branch September 4, 2018 16:39
@jasonrsadler jasonrsadler mentioned this pull request Sep 5, 2018
Closed
@NejcZdovc NejcZdovc added this to the Closed milestone Mar 6, 2020
@NejcZdovc NejcZdovc modified the milestones: Closed, 0.55.x - Release Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong left review comments

@bbondy bbondy bbondy approved these changes

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonrsadler @bbondy @simonhong @NejcZdovc