Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round-robin Brave Ads campaign advertisers to reduce the frequency of showing the same ad #4459

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 29, 2020

Fixes brave/brave-browser#7888
Requires #4558

Submitter Checklist:

Test Plan:

  • Confirm advertisers (campaigns) for a catalog with one campaign round-robin before showing the same advertiser
  • Confirm advertisers (campaigns) for a catalog with multiple campaigns round-robin before showing the same advertiser
  • Confirm ads round-robin before showing the same ad

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey self-assigned this Jan 29, 2020
@tmancey tmancey requested review from emerick and NejcZdovc January 29, 2020 01:42
@tmancey tmancey modified the milestone: 1.5.x - Nightly Jan 29, 2020
@tmancey tmancey added this to the 1.4.x - Beta milestone Feb 5, 2020
@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Feb 6, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Feb 6, 2020

macOS failed, restarting CI for macOS

@bbondy
Copy link
Member

bbondy commented Feb 6, 2020

Per discussion with Terry on Slack, merging.

@bbondy bbondy merged commit cd4edd3 into master Feb 6, 2020
@bbondy bbondy deleted the issues/7888 branch February 6, 2020 20:30
@tmancey tmancey removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux PR/Pending Review labels Feb 6, 2020
@tmancey tmancey modified the milestones: 1.4.x - Beta, 1.6.x - Nightly Feb 6, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round-robin Brave Ads campaign advertisers to reduce the frequency of showing the same ad
3 participants