Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return balance if connected state #4667

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Don't return balance if connected state #4667

merged 1 commit into from
Feb 18, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 17, 2020

Resolves brave/brave-browser#8075

Submitter Checklist:

Test Plan:

  • enable rewards
  • connect connected uphold wallet that has some balance
  • make sure that connection was successful
  • make sure that balance is still 0
  • make sure that you don't see any requests going out like https://api-sandbox.uphold.com/v0/me/cards/a6dff2ba-d0d1-41c4-8e56

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.6.x - Nightly milestone Feb 17, 2020
@NejcZdovc NejcZdovc self-assigned this Feb 17, 2020
@NejcZdovc NejcZdovc requested a review from a team February 18, 2020 05:53
@NejcZdovc
Copy link
Contributor Author

CI failed on test-browser for (AutoplayPermissionContextBrowserTest.BlockAutoplay) and xUnit test. Both not related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop specific: Changes in non KYC Uphold user wallet state
3 participants