Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes assertion thrown in debug builds when generating Brave Ads console log report #4774

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 27, 2020

Resolves brave/brave-browser#8446

Submitter Checklist:

Test Plan:

Confirm "restart" appears within an AdsService Event Log: in the console log when viewing Brave Ad notifications

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@tmancey
Copy link
Collaborator Author

tmancey commented Feb 27, 2020

Failed due to audit and s3 upload

@tmancey tmancey merged commit 7283b1e into master Feb 27, 2020
@tmancey tmancey deleted the issues/8446 branch February 27, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion thrown in debug builds when generating Brave Ads console log report
3 participants