Recreating bookmarks with duplicated sync object id

[AlexeyBarabash]

Resolves brave/brave-browser#8358

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed). First two commits I will squash after review
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

1. Install version 1.7.20 Nightly, or any other based on C80 which does not contain Sync fix bookmarks object id duplication #4710
2. Enable sync through flags
3. Create sync chain, no need to connect 2nd device
4. Create bookmark
5. Copy and paste bookmark
6. See crash
7. Install the version containing this fix
8. Launch - should not be crash
9. Connect 2nd device to chain - bookmarks changes should be reflected, may take 11 minutes

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[BrendanEich]

Note duplicated_bookmarks_recorvered typo ("recovered" as "recorvered").

[AlexeyBarabash]

Here what happens step-by-step.

1. BookmarkModel is loaded BookmarkModel::DoneLoading;
2. Also sync_metadata_str() is passed eventually into BookmarkModelTypeProcessor::ModelReadyToSync
   bookmark meta info is decoded and there are such info about bookmarks:

sync_pb::BookmarkMetadata
	is_deleted
	server_id
	sequence_number
	acked_sequence_number

3. Recovery procedure BraveProfileSyncServiceImpl::MigrateDuplicatedBookmarksObjectIds runs

4. In this point sync_bookmarks::BookmarkModelObserverImpl already is set as bookmark model observer
   and it processes BookmarkNodeAdded and BookmarkNodeRemoved caused by MigrateDuplicatedBookmarksObjectIds operations

5. records DELETE and CREATE comes into ConvertCommitsToBraveRecords
   Here for the entity we want to delete, brave sync object_id is empty. For such record I set objectId to a new generated. This allows the record to travel through cyns cycle and do not appear as unsynced in the future.

6. Previos steps happens early on browser start so BraveProfileSyncServiceImpl::SendSyncRecords will be executed before extension is initialized, so actual records will be resent after 10 minutes actually. This what had happened in issue Some bookmarks with duplicate ids are not synced brave-browser#8498.

7. In 10 minutes resend will happened and all other devices in chain will have that info.

[AlexeyBarabash]

CI failed because of audit failures and internal error of lynt.py.

[AlexeyBarabash]

removed b-b branch and rebased

[AlexeyBarabash]

on linux failed browser-test

1 test timed out:
15:18:11      BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2762)

macos failed completely
windows was skipped
android succeeded
ios succeeded

restarting all except android and ios

[bridiver]

chromium_src changes are ok