Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation icon is visible after installing g-translate extension (uplift to 1.7.x) #4929

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 13, 2020

Uplift of #4928

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Mar 13, 2020
@brave-builds brave-builds added this to the 1.7.x - Beta milestone Mar 13, 2020
@simonhong simonhong self-assigned this Mar 13, 2020
@kjozwiak
Copy link
Member

Looks like most of the failures where due to lint failing. However, this is a known issue and will be resolved via brave/brave-browser#8684.

Android failing lint --> hhttps://ci.brave.com/job/brave-browser-build-pr/job/pr4928_issue_8082_tr_icon_1.7.x/2/execution/node/372/log/
iOS failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/pr4928_issue_8082_tr_icon_1.7.x/2/execution/node/318/log/
Linux failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/pr4928_issue_8082_tr_icon_1.7.x/2/execution/node/339/log/
macOS failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/pr4928_issue_8082_tr_icon_1.7.x/2/execution/node/339/log/

Restarting Win x64 as the user agent was disconnected and build failed as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4928_issue_8082_tr_icon_1.7.x/2/execution/node/465/log/

09:18:41  Cannot contact i-096b5f5f86aa9b5ad: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel

Restarting Linux due to test-browser failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4928_issue_8082_tr_icon_1.7.x/2/execution/node/526/log/.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 13, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. As per #4929 (comment), lint failed on all the platforms which is expected. The failure isn't related to this particular PR and has already beed addressed. QA has also run through the PR as per #4928 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit b3f5882 into 1.7.x Mar 13, 2020
@kjozwiak kjozwiak deleted the pr4928_issue_8082_tr_icon_1.7.x branch March 13, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants