Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes contribution that is split (uplift to 1.7.x) #5077

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fixes contribution that is split (uplift to 1.7.x) #5077

merged 1 commit into from
Mar 27, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 26, 2020 •
edited by kjozwiak
Loading

Uplift of #5050

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc self-assigned this Mar 26, 2020
@NejcZdovc NejcZdovc added this to the 1.7.x - Beta milestone Mar 26, 2020
@NejcZdovc
Copy link
Contributor Author

CI only failed on windows dist, all good

@NejcZdovc NejcZdovc requested a review from a team March 27, 2020 06:10
kjozwiak
kjozwiak approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 76646a8 into 1.7.x Mar 27, 2020
@kjozwiak kjozwiak deleted the unblinded-contribution-1.7 branch March 27, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @kjozwiak