Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave Stat text on New Tab Page from "Ads and Trackers blocked" to "Trackers & ads blocked" (1.10.x). #5714

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 2, 2020

Resolves brave/brave-browser#9692
Resolves brave/brave-browser#9838

Uplift from #5630

cc: @bsclifton @rebron

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Update Brave Stat text on New Tab Page from "Ads and Trackers blocked" to "Trackers & ads blocked"
@mkarolin mkarolin added this to the 1.10.x - Beta milestone Jun 2, 2020
@mkarolin mkarolin requested a review from a team June 2, 2020 14:44
@mkarolin mkarolin self-assigned this Jun 2, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ since this is needed for translations 😄

Marked as CI/skip since this only has text changes which already work great when testing locally

@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Jun 3, 2020
@bsclifton bsclifton merged commit 12f4a41 into 1.10.x Jun 3, 2020
@bsclifton bsclifton deleted the maxk-change-brave-stats-text-ntp-1.10.x branch June 3, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants