Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fire notifications on initialization (uplift to 1.11.x) #6148

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 21, 2020

Uplift of #6126
fix brave/brave-browser#9481

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team July 21, 2020 15:51
@brave-builds brave-builds self-assigned this Jul 21, 2020
@bsclifton bsclifton force-pushed the pr6126_issues/9481_1.11.x branch from 02b7738 to f79afa5 Compare July 21, 2020 23:47
@bsclifton
Copy link
Member

bsclifton commented Jul 22, 2020

CI failing because #6161 and brave/brave-browser#10843 need to be merged first. Then we can rebase/restart this build

@kjozwiak
Copy link
Member

Restarting now that brave/brave-browser#10843 has been merged into 1.11.x.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 22, 2020

Looks like init failed on all the plaforms once again due to the following:

14:39:19  Error: Command 'vpython src/brave/script/build-simple-js-bundle.py --repo_dir_path src/brave/components/brave_sync/extension/brave-sync-android' returned non-zero exit status 1 in /home/ubuntu/workspace/pr-brave-browser-pr6126_issues-9481_1.11.x/src/brave

@jumde jumde force-pushed the pr6126_issues/9481_1.11.x branch from f79afa5 to 6533218 Compare July 22, 2020 19:59
@kjozwiak
Copy link
Member

Looks like npm run audit_deps failed due to lodash on every platform which is a known issue that's already been fixed on 1.13.x and 1.12.x.

Restarting Win x64 as build failed due to Agent was removed as per https://ci.brave.com/job/pr-brave-browser-pr6126_issues-9481_1.11.x/6/execution/node/593/log/

17:23:20  Cannot contact i-059db4936299211f9: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@fa5dfd9:i-059db4936299211f9": Remote call on i-059db4936299211f9 failed. The channel is closing down or has closed down
17:28:22  Could not connect to i-059db4936299211f9 to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 22, 2020
@kjozwiak
Copy link
Member

Remaining failure on Win x64 is due to npm run audit_deps which is a known issue on 1.11.x.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6126 (comment).

@kjozwiak kjozwiak merged commit 3d0e9e2 into 1.11.x Jul 23, 2020
@kjozwiak kjozwiak deleted the pr6126_issues/9481_1.11.x branch July 23, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants