Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shields "advanced view" backfill code #6845

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

bsclifton
Copy link
Member

This was intended to lock in advanced view for existing users and has
done its job :) It's now obsolete

Fixes brave/brave-browser#12104

This contains a manual revert of #3154 and #4860

Resolves

Submitter Checklist:

Test Plan:

n/a

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Sorry, something went wrong.

This was intended to lock in advanced view for existing users and has
done its job :) It's now obsolete

Fixes brave/brave-browser#12104

This contains a manual revert of #3154 and #4860
@bsclifton bsclifton added this to the 1.17.x - Nightly milestone Oct 13, 2020
@bsclifton bsclifton requested a review from bridiver October 13, 2020 05:58
@bsclifton bsclifton self-assigned this Oct 13, 2020
@bsclifton
Copy link
Member Author

macOS CI failure is just for test-install failure; not a blocker. Ready for review, @bridiver 😄

@bsclifton bsclifton merged commit 00513bb into master Oct 20, 2020
@bsclifton bsclifton deleted the bsc-remove-shields-advanced-view-backfill branch October 20, 2020 07:27
@bsclifton
Copy link
Member Author

cc: @kjozwiak @LaurenWags @srirambv @GeetaSarvadnya @btlechowski

No testing needed - but just a heads up that the backfilling for this profile preference was removed. New users always default to simple view; this was setting existing users to advanced. Please let me know if you see anything weird in Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove shields "advanced view" backfill code
2 participants