Use official ghcr.io/tideways/php docker image for Tideways installation
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation The provided tooling will do the heavy lifting of choosing the correct `.so` file for a given PHP version, it will automatically support other architectures and downloading and verification is handled by Docker instead of a manual `curl` command.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I assume this works, but I don't know about bref and thus couldn't end-to-end test it. I verified locally that the Docker image still builds and that the result is identical using diffoci.
The provided tooling will do the heavy lifting of choosing the correct
.sofile for a given PHP version, it will automatically support other architectures and downloading and verification is handled by Docker instead of a manualcurlcommand.