-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nasm #905
Add support for nasm #905
Conversation
@Jake-Shadle Are you interested in updating this based on the above feedback? |
4c1c9be
to
f19a047
Compare
Thanks for the PR and thanks for updating it in response to my previous comment. I haven't had time to test it out but I will do so if/when you rebase it. I think we should check to see which version of nasm BoringSSL is using and use the same version. |
I updated the version to the one that boringssl ostensibly is using as seen https://boringssl.googlesource.com/boringssl/+/HEAD/util/bot/UPDATING#56 |
@Jake-Shadle Thanks for the PR. I had to rewrite the CI/CD to replace Travis CI and AppVeyor with GitHub Actions. That makes your PR unmergable. I'm going to close this. I have written a new PR #1123 that attempts to accomplish the same thing yours does. I would appreciate it if you could take a look. |
I was having issues with yasm on Windows, and noticed #752, so I just tried out nasm instead and everything seemed to work.
Resolves: #752