Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fapi.create_submission to enable Terra features such as delete intermediate output files #165

Closed
bli25 opened this issue Sep 8, 2021 · 0 comments · Fixed by #175
Closed

Update fapi.create_submission to enable Terra features such as delete intermediate output files #165

bli25 opened this issue Sep 8, 2021 · 0 comments · Fixed by #175

Comments

@bli25
Copy link

bli25 commented Sep 8, 2021

Dear Sir./Madam.,

According to FireCloud API https://api.firecloud.org/#/Submissions/createSubmission

We have the following new parameters that fapi.create_submission currently do not accept.

"deleteIntermediateOutputFiles": true,
"useReferenceDisks": true,
"memoryRetryMultiplier": 0,
"workflowFailureMode": "NoNewCalls",

Can I know when do we plan to add these parameters?

Thanks,
Bo
dheiman added a commit that referenced this issue Jul 25, 2022
@dheiman
v0.16.32 - initial commit
12d3fd7 
* Changed Dockerfile base image to python 3.10
* Fixed Python 3.10 incompatibility issues (fixes #170)
* pylint set to minimum version 2.0.0 (fixes #168)

api.py:
* added `__patch()` helper to simplify adding wrappers for `PATCH` API
calls
* enhanced error checking to use the more robust json decoder in the
`requests` module
* `upload_entities()`: added `delete_empty` parameter
* `get_entities_query()`: added `filter_operator` and `fields`
parameters
* `create_submission()`: added `deleteIntermediateOutputFiles`,
`useReferenceDisks`, `memoryRetryMultiplier`, `workflowFailureMode`, and
`userComment` fields (fixes #165, #169)
* `create_workspace()`: added `noWorkspaceOwner` and `bucketLocation`
fields and enabled use of multiple authorization domains (fixes #171)
* new helper functions: `_attr_vlcreate()` and `_attr_erlcreate()` for
creating list attribute via `update_workspace_attributes()` and
`update_entity()` (resolves #99)
* fixed bugs in existing helper functionss `_attr_ladd()` and
`_attr_lrem()`
* new functions:
   - `delete_entities_of_type()`
   - `rename_entity()`
   - `rename_entity_type()`
   - `rename_entity_type_attribute()`
* updated and cleaned up documentation for multiple functions

`fiss.py`:
* new functions:
   - `entity_rename()`
   - `attr_rename()`
* function updates:
   - helper `_entity_paginator()` updated to take advantage of the
`fields` parameter to speed up queries
   - `config_start()` updated to use new `api.create_submission()`
fields
   - `attr_get()` now returns formatted arrays for list attributes in
workspaces
   - `attr_set()` updated to enable creation of value and reference list
attributes
   - `attr_delete()` updated to be completely type agnostic (previously
only guaranteed to work on entity types in the firecloud model)
   - `space_new()` updated to allow multiple authorization domains and
set the bucket region for the new workspace
* Cleaned up return of Terra errors to be more human-readable

`highlevel_tests.py`:
* updated include new rename functions
* fixed bugs that were due to inaccurate API docs

`lowlevel_tests.py`:
* added test for `get_entities_query()`.
@dheiman dheiman mentioned this issue Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.16.32 broadinstitute/fiss
1 participant
@bli25