-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalise method to distribute Code Review Asignees. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for trying this out! This is an experiment, so it's worth keeping the pros and cons in mind as we try it out. Potential benefits: increased fairness, transparency, objectivity, reproducibility, encourages participation. Potential downsides: added complexity, the risk of discouraging organic collaboration, and the possibility of gaming the system or overemphasizing quantity over quality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an urgent PR. Based on a chat with @shntnu, we are coming up with a way to distribute code reviews in a way that is fair to everyone. To do so, we first ought to know who is reviewing and has reviewed other PRs before. This is not directly accessible through GitHub so I use one of dogsheep's tools to fetch it. Then I use datasette to visualise it on the browser, which makes it universally accessible.
The current way to do this requires the installation of two packages (github-to-sqlite and datasette). I added pyproject.toml and poetry.lock files to make this reproducible. Producing the data requires one command and opening in a browser another, making it pretty accessible. Adding the toml and lock files may be an overkill, but it ensures reproducibility.
The alternative is to use Github Actions to automate this and put the .db somewhere accessible, then access it with datasette-lite. The downside is that managing credentials and auth to upload the updated database somewhere will add overhead. I'd like to get opinions from @leoank on this matter, even if I'm not suggesting him as a reviewer.
Other opinions on how to distribute code-reviews in an unbiased manner are welcome.
Let me know if anything else needs to be done to merge this. I didn't put it in ./libs as it is more of a management module, so I created the ./management/ folder for these things.
See example of asignee's visualisation. Here the number on the right of the usernames is the number of pull-requests in which they are involved:

Instructions on how to reproduce this can be found here.