Set env when job cancelled for hooks #3213
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that hook behaviour can change when the job has cancelled, either from the platform or because the agent is being stopped, and so its result is likely inconsequential. We have some customers who would like to use this to avoid sending a notification to a system about a result that doesn't matter because it is either incomplete or will be retried.
Alternative to #3201 / PIPE-481.
Testing
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)This could use an additional automated test but I'm not sure how complicated that'll be. But this seems a pretty low-risk change in any case.
I manually tested by adding a post-command hook like this:
and it worked a treat:
That should also cover when the agent is stopped forcefully which also cancels the job.