-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check in setup.py #416
Conversation
I think we should bump minimal python version to 3.10 anyway, so you can change that. The refurbishment pull request makes that possible and seamless right? |
Yes, the refurbishment was performed with Python 3.12 in mind when running |
So maybe can you set check for python 3.12 and just make it 3.12 project :) I think it is time |
Alright. I have added minor fixes as well. |
By the way, maybe, I am missing something, but I don't see where Lines 56 to 69 in 33a5cd9
before it is used in: self.session.cookies.set(**store_cookie) |
Merged manually, thanks! |
Add the check which was removed by mistake in:
The check was removed due to https://docs.astral.sh/ruff/rules/outdated-version-block/, because the target version was higher than 3.8.