Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check in setup.py #416

Closed
wants to merge 10 commits into from
Closed

Add check in setup.py #416

wants to merge 10 commits into from

Conversation

woctezuma
Copy link
Contributor

@woctezuma woctezuma commented Dec 2, 2024

Add the check which was removed by mistake in:

The check was removed due to https://docs.astral.sh/ruff/rules/outdated-version-block/, because the target version was higher than 3.8.

@bukson
Copy link
Owner

bukson commented Dec 2, 2024

I think we should bump minimal python version to 3.10 anyway, so you can change that. The refurbishment pull request makes that possible and seamless right?

@woctezuma
Copy link
Contributor Author

Yes, the refurbishment was performed with Python 3.12 in mind when running ruff.

@bukson
Copy link
Owner

bukson commented Dec 10, 2024

So maybe can you set check for python 3.12 and just make it 3.12 project :) I think it is time

@woctezuma
Copy link
Contributor Author

Alright. I have added minor fixes as well.

@woctezuma
Copy link
Contributor Author

woctezuma commented Dec 10, 2024

By the way, maybe, I am missing something, but I don't see where store_cookie is defined in:

steampy/steampy/login.py

Lines 56 to 69 in 33a5cd9

def set_sessionid_cookies(self):
community_domain = SteamUrl.COMMUNITY_URL[8:]
store_domain = SteamUrl.STORE_URL[8:]
community_cookie_dic = self.session.cookies.get_dict(domain = community_domain)
store_cookie_dic = self.session.cookies.get_dict(domain = store_domain)
for name in ('steamLoginSecure', 'sessionid', 'steamRefresh_steam', 'steamCountry'):
cookie = self.session.cookies.get_dict()[name]
if name in ["sessionid", "steamLoginSecure"]:
community_cookie = create_cookie(name, community_cookie_dic[name], community_domain)
else:
community_cookie = create_cookie(name, cookie, community_domain)
self.session.cookies.set(**community_cookie)
self.session.cookies.set(**store_cookie)

before it is used in:

self.session.cookies.set(**store_cookie)  

@bukson
Copy link
Owner

bukson commented Dec 23, 2024

Merged manually, thanks!

@bukson bukson closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants