Trait based refactor of Ellipsoid #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ellipsoid impl was huge and unmaintainable. Now it has been split into an EllipsoidBase trait, defining the fundamental shape and size parameters, and a number of more specialized traits for latitudes, meridian-geometry, geodesics, cartesians (geocart), and gravity. Also lib.rs was cleaned up to reflect the new structure, and the prelude has been rebuilt using thematical modules: coord, ctx, and ellps, representing coordinate, context, and ellipsoidal material, respectively. Likewise, the "authoring" extended prelude has been restructured through the introduction of the grd, ops, and parse modules. Finally, a number of documentation improvements were introduced while refactoring the existing material to reflect the new structure. For usage based on the "use geodesy::prelude::*" idiom, no user visible changes are expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ellipsoid impl was huge and unmaintainable.
Now it has been split into an EllipsoidBase trait, defining the fundamental shape and size parameters, and a number of more specialized traits for latitudes, meridian-geometry, geodesics, cartesians (geocart), and gravity.
Also lib.rs was cleaned up to reflect the new structure, and the prelude has been rebuilt using thematical modules: coord, ctx, and ellps, representing coordinate, context, and ellipsoidal material, respectively.
Likewise, the "authoring" extended prelude has been restructured through the introduction of the grd,
ops, and parse modules.
Finally, a number of documentation improvements were introduced while refactoring the existing material to reflect the new structure.
For usage based on the "use geodesy::prelude::*" idiom, no user visible changes are expected.