Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer versions of requests #101

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Allow newer versions of requests #101

merged 3 commits into from
Jan 14, 2025

Conversation

mrdavidlaing
Copy link
Contributor

@bvanelli
Copy link
Owner

bvanelli commented Jan 6, 2025

Hello, thanks for the submission.

As far as I know the version was pinned because of a docker bug: psf/requests#6707

You would also need to bump the version on requirements.txt too, and perhaps also the docker version.

Could you test offline with those changes?

@bvanelli
Copy link
Owner

I tested and you need to also fix the docker version. Could you do this in addition?

diff --git a/requirements-dev.txt b/requirements-dev.txt
index 047523e..8e2f73f 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -3,3 +3,4 @@ pytest
 pytest-cov
 testcontainers
 pre-commit
+docker>=7.1.0
diff --git a/requirements.txt b/requirements.txt
index d2f84d5..34817c8 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
-requests>=2,<2.32.0
+requests>=2
 sqlmodel>=0.0.18
 pydantic>=2,<3
 sqlalchemy>=2

@bvanelli bvanelli merged commit 9cf1ab5 into bvanelli:main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants