This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Add CLI configuration for memory limits and improve performance for large initial heaps #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
jedisct1
previously approved these changes
Mar 29, 2019
ghost
changed the title
|
Hey Adam, Can you fix the conflicts, so this can be merged? That would be great :) |
Rather than explicitly zeroing, use `madvise` and `mprotect` to zero the heap. We also now make sure the heap address space is at least as big as the memory size when validating `Limits`.
- Heap limits are set to maximum for a 32-bit address space + 32-bit guard size - Stack size is set to 8MiB to match Linux's default - Globals size is calculated from the module
ghost
force-pushed
the
acf/lucet-wasi-memory-cli
branch
from
d68f8f3 to
0958c18
Compare
jedisct1
previously approved these changes
Mar 29, 2019
Instead of a single `reserved-size` argument, `lucetc` now optionally takes `--min-reserved-size` and `--max-reserved-size`. By default, the minimum is 4 KiB, and the maximum is 6 GiB (the entire possible wasm address space, plus extra room for bounds check elision). In the case that the module's initial heap size is larger than the minimum, we use the initial heap size as the reserved size. In the case that the initial size is larger than the maximum, compilation fails.
ghost
force-pushed
the
acf/lucet-wasi-memory-cli
branch
from
0958c18 to
b563370
Compare
jedisct1
approved these changes
Mar 29, 2019
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds command-line parameters to
lucet-wasito control the memory limits, and raises the default values of those limits substantially. Most users will only ever need to turn them down, not up.Also, this reworks the way reserved size is set in
lucetcto provide fewer surprises; see b563370.Finally, this switches to relying on
madviseto zero the instance heap when an instance is reset or created, substantially improving performance for programs with large initial heaps.Closes #74 and #76