Fix printing float results from the CLI (#2797)

Previously their bit patterns were printed interpreted as decimals, now they're printed as floats.
bytecodealliance · Apr 2, 2021 · 2994950 · 2994950
1 parent 90aa5cf
commit 2994950
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/src/commands/run.rs b/src/commands/run.rs
@@ -333,10 +333,10 @@ impl RunCommand {
             match result {
                 Val::I32(i) => println!("{}", i),
                 Val::I64(i) => println!("{}", i),
-                Val::F32(f) => println!("{}", f),
-                Val::F64(f) => println!("{}", f),
+                Val::F32(f) => println!("{}", f32::from_bits(f)),
+                Val::F64(f) => println!("{}", f64::from_bits(f)),
                 Val::ExternRef(_) => println!("<externref>"),
-                Val::FuncRef(_) => println!("<externref>"),
+                Val::FuncRef(_) => println!("<funcref>"),
                 Val::V128(i) => println!("{}", i),
             }
         }

diff --git a/tests/all/cli_tests.rs b/tests/all/cli_tests.rs
@@ -97,6 +97,26 @@ fn run_wasmtime_simple_wat() -> Result<()> {
         "--disable-cache",
         "4",
     ])?;
+    assert_eq!(
+        run_wasmtime(&[
+            "run",
+            wasm.path().to_str().unwrap(),
+            "--invoke",
+            "get_f32",
+            "--disable-cache",
+        ])?,
+        "100\n"
+    );
+    assert_eq!(
+        run_wasmtime(&[
+            "run",
+            wasm.path().to_str().unwrap(),
+            "--invoke",
+            "get_f64",
+            "--disable-cache",
+        ])?,
+        "100\n"
+    );
     Ok(())
 }
 

diff --git a/tests/wasm/simple.wat b/tests/wasm/simple.wat
@@ -2,4 +2,6 @@
     (func (export "simple") (param i32) (result i32)
         local.get 0
     )
-)
+    (func (export "get_f32") (result f32) f32.const 100)
+    (func (export "get_f64") (result f64) f64.const 100)
+)