Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi-common: remove unnecessary check - fixed in std since Rust 1.38 #2164

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

pchickey
Copy link
Contributor

issue now closed: rust-lang/rust#63326
fix landed in a rollup: rust-lang/rust#63380 merged aug 8, 2019
rust 1.38 beta cut on aug 15, 2019: https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html
minimum supported rust version for this repo is currently 1.41.

issue now closed: rust-lang/rust#63326
fix landed in a rollup: rust-lang/rust#63380 merged aug 8, 2019
rust 1.38 beta cut on aug 15, 2019: https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html
minimum supported rust version for this repo is currently 1.41.
@pchickey pchickey requested a review from aturon August 26, 2020 00:33
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Aug 26, 2020
@github-actions
Copy link

Subscribe to Label Action

cc @kubkon

This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@aturon aturon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pchickey pchickey merged commit 19393be into main Aug 26, 2020
@pchickey pchickey deleted the pch/remove_truncate_check branch August 26, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File::set_len uses an unsafe cast on Unix
2 participants