x64: fix Inst::store to understand all scalar types #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Inst::store` only understood a subset of the scalar types, which resulted in failures seen in bytecodealliance#2826. This change allows `Inst::store` to generate instructions for all scalar widths (`8 | 16 | 32 | 64`) since all of these are supported in the emission code of `Inst::MovRM`.
This re-factoring replaces uses of `Inst::mov_r_m` with `Inst::store` to ensure there is only one code location to troubleshoot when generating store instructions for a specific type.
github-actions
bot
added
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2826, @bjorn3 found an issue relating to
Inst::store--not all types, e.g.I16, were supported. There is no reasonInst::storeshouldn't have this functionality: the emission ofMovRMalready supports this. @bjorn3, can you provide a CLIF test to trigger the error you found?Also, to make troubleshooting easier in the future, I re-factored
lower.rsto useInst::storein all the places it previously usedInst::mov_r_m. This should make things easier to troubleshoot: only one function,Inst::store, now understands what move instruction is needed for each different CLIF type.