Code

Initial ISLE integration for x64#3506

Code

Merged

fitzgen merged 95 commits intobytecodealliance:mainbytecodealliance/wasmtime:mainfrom fitzgen:islefitzgen/wasmtime:isleCopy head branch name to clipboardNov 15, 2021

+16,205-1,191

Commits

Commits on Oct 13, 2021

• Initial ISLE integration with the x64 backend

  Show description for d377b66
  fitzgen

  committed
  d377b66

  Copy full SHA for d377b66

Commits on Nov 5, 2021

• ISLE: add a missing type check for whether terms used in expressions have a constructor

  fitzgen

  committed
  00e7ca2

  Copy full SHA for 00e7ca2

• x64: Remove some unreachable code that's been ported to ISLE

  fitzgen

  committed
  30d2067

  Copy full SHA for 30d2067

• ISLE: finish porting imul lowering to ISLE

  fitzgen

  committed
  b849482

  Copy full SHA for b849482

• ISLE: run rustfmt on generated code

  fitzgen

  committed
  7a568b1

  Copy full SHA for 7a568b1

Commits on Nov 10, 2021

• ISLE: use lower_to_amode inside sink_load implementation

  fitzgen

  committed
  bbb4949

  Copy full SHA for bbb4949

• MachInst: always rematerialize constants, rather than assign them registers

  Show description for b5105c0
  fitzgen

  committed
  b5105c0

  Copy full SHA for b5105c0

• x64: special case 0 to use xor in Inst::gen_constant for i128s

  fitzgen

  committed
  33fcd6b

  Copy full SHA for 33fcd6b

Commits on Nov 11, 2021

• ISLE: implement x64 lowering for band_not in ISLE

  fitzgen

  committed
  bfbf2f2

  Copy full SHA for bfbf2f2

• Initial public commit of ISLE prototype DSL compiler.

  cfallin

  committed
  84b7612

  Copy full SHA for 84b7612

• WIP: rip out a bunch of stuff and rework

  cfallin

  committed
  e081608

  Copy full SHA for e081608

• WIP

  cfallin

  committed
  6a56792

  Copy full SHA for 6a56792

• WIP -- more thinking about how to work priorities into FSM

  cfallin

  committed
  f2399c5

  Copy full SHA for f2399c5

• Start of significant rework: compile to a trie, not an FSM, and handle rule priorities appropriately.

  Show description for 77ed861
  cfallin

  committed
  77ed861

  Copy full SHA for 77ed861

• trie insertion

  cfallin

  committed
  02ec77a

  Copy full SHA for 02ec77a

• skeleton for codegen

  cfallin

  committed
  5aa72bc

  Copy full SHA for 5aa72bc

• Generate internal enum types.

  cfallin

  committed
  e9a57d8

  Copy full SHA for e9a57d8

• Support for file input and output, including multiple input files with proper position tracking.

  cfallin

  committed
  638c9ed

  Copy full SHA for 638c9ed

• more codegen WIP: start to generate functions

  cfallin

  committed
  8c727b1

  Copy full SHA for 8c727b1

• WIP.

  cfallin

  committed
  e5d76db

  Copy full SHA for e5d76db

• WIP.

  cfallin

  committed
  cd55dc9

  Copy full SHA for cd55dc9

• WIP.

  cfallin

  committed
  be1140e

  Copy full SHA for be1140e

• Working extractor and constructor generation from rules!

  cfallin

  committed
  d7efd9f

  Copy full SHA for d7efd9f

• Working example and README

  cfallin

  committed
  4a2cd78

  Copy full SHA for 4a2cd78

• Add TODO

  cfallin

  committed
  bc91a4e

  Copy full SHA for bc91a4e

• Another example, testing rule priorities a bit

  cfallin

  committed
  b8e916a

  Copy full SHA for b8e916a

• Update long block comment describing priority trie in codegen.rs.

  cfallin

  committed
  7865191

  Copy full SHA for 7865191

• Priority-trie: merge edges with different priorities into ranges when possible.

  cfallin

  committed
  ed4c857

  Copy full SHA for ed4c857

• Generate match {} statements by merging adjacent MatchVariant trie edges.

  cfallin

  committed
  3ccbaf0

  Copy full SHA for 3ccbaf0

• Codegen: parameterize on a generated Context trait that contains external ctors/etors.

  cfallin

  committed
  d725ac1

  Copy full SHA for d725ac1

• More work on sketch for isel and some TODO items derived from it.

  cfallin

  committed
  602b830

  Copy full SHA for 602b830

• (and ...) combinator in patterns

  cfallin

  committed
  1ceef04

  Copy full SHA for 1ceef04

• Initial draft of DSL semantics complete.

  Show description for 6daa55a
  cfallin

  committed
  6daa55a

  Copy full SHA for 6daa55a

• Infallible extractors, and some fixes to fallibility in return types (Option<T> vs T).

  cfallin

  committed
  a412cce

  Copy full SHA for a412cce

• Support for bools. Also fix fallible/infallible mixup for ctors.

  cfallin

  committed
  edc95c5

  Copy full SHA for edc95c5

• Some test cases for arg-less enums.

  cfallin

  committed
  3f96068

  Copy full SHA for 3f96068

• Some fixes to the internal-extractor macro substitution

  cfallin

  committed
  5a8e35b

  Copy full SHA for 5a8e35b

• Remove old .gitmodules -- no longer using wasmtime as a submodule

  cfallin

  committed
  af9e01a

  Copy full SHA for af9e01a

• Remove old/no longer used lower.rs

  cfallin

  committed
  b46fa6a

  Copy full SHA for b46fa6a

• Revamped error handling: keep going beyond some errors to accumulate a list of build errors, like most conventional compilers.

  cfallin

  committed
  7d38b3b

  Copy full SHA for 7d38b3b

• Properly track locations on every AST node. Semantic errors are much more useful now. Also print parse errors in same (pseudo-standard compiler error) output format.

  cfallin

  committed
  2a574b1

  Copy full SHA for 2a574b1

• README update.

  cfallin

  committed
  3ed146b

  Copy full SHA for 3ed146b

• bugfix to macro template generation: exclude Pos on ident from equality (broken by recent commit)

  cfallin

  committed
  83672a8

  Copy full SHA for 83672a8

• Refactor to allow use as library, in order to allow build.rs usage.

  cfallin

  committed
  e751f12

  Copy full SHA for e751f12

• Split into isle and islec crates

  cfallin

  committed
  521010c

  Copy full SHA for 521010c

• TODO update.

  cfallin

  committed
  d0ace64

  Copy full SHA for d0ace64

• Support extern constants of any primitive type.

  cfallin

  committed
  20bc5ca

  Copy full SHA for 20bc5ca

• TODO items from call with fitzgen

  cfallin

  committed
  91904aa

  Copy full SHA for 91904aa

• Remove TODO we don't want to do

  Show description for 66ba1d8
  

  fitzgen

  authored and

  cfallin

  committed
  66ba1d8

  Copy full SHA for 66ba1d8

• Use matches!(..) to make TrieNode::is_empty more concise

  

  fitzgen

  authored and

  cfallin

  committed
  5f5484d

  Copy full SHA for 5f5484d

• Update TODO

  

  fitzgen

  authored and

  cfallin

  committed
  012f4b0

  Copy full SHA for 012f4b0

• Remove an unused field in TermFunctionBuilder

  

  fitzgen

  authored and

  cfallin

  committed
  3535f82

  Copy full SHA for 3535f82

• Don't use &mut dyn Write in codegen

  Show description for 972dc00
  

  fitzgen

  authored and

  cfallin

  committed
  972dc00

  Copy full SHA for 972dc00

• Fix let variable typing rules

  

  fitzgen

  authored and

  cfallin

  committed
  922a388

  Copy full SHA for 922a388

• Add docs to all public exports and deny(missing_docs) going forward

  

  fitzgen

  authored and

  cfallin

  committed
  b93304b

  Copy full SHA for b93304b

• Switch to using thiserror

  

  fitzgen

  authored and

  cfallin

  committed
  38da2ce

  Copy full SHA for 38da2ce

• Use miette for reporting errors

  Show description for 6ffb02d
  

  fitzgen

  authored and

  cfallin

  committed
  6ffb02d

  Copy full SHA for 6ffb02d

• Use structopt to derive CLI flags

  Show description for cfaa35d
  

  fitzgen

  authored and

  cfallin

  committed
  cfaa35d

  Copy full SHA for cfaa35d

• Define a fuzz target for the parser

  

  fitzgen

  authored and

  cfallin

  committed
  8252589

  Copy full SHA for 8252589

• Fix overflows when tokenizing integer literals

  

  fitzgen

  authored and

  cfallin

  committed
  6a52393

  Copy full SHA for 6a52393

• Fix some panics on parsing error paths

  

  fitzgen

  authored and

  cfallin

  committed
  f2b6244

  Copy full SHA for f2b6244

• Fix a panic when parsing var patterns

  

  fitzgen

  authored and

  cfallin

  committed
  e3aeb85

  Copy full SHA for e3aeb85

• Add a top-level parse function

  Show description for 6604a26
  

  fitzgen

  authored and

  cfallin

  committed
  6604a26

  Copy full SHA for 6604a26

• Use .copied() instead of .cloned()

  

  fitzgen

  authored and

  cfallin

  committed
  9be1942

  Copy full SHA for 9be1942

• Extend fuzzing to semantic analysis and codegen

  Show description for a099b2b
  

  fitzgen

  authored and

  cfallin

  committed
  a099b2b

  Copy full SHA for a099b2b

• Check that integer literals are a primitive type

  

  fitzgen

  authored and

  cfallin

  committed
  ce207ee

  Copy full SHA for ce207ee

• Check that integer literals are primitive types in patterns

  

  fitzgen

  authored and

  cfallin

  committed
  d2bd07c

  Copy full SHA for d2bd07c

• Make sure that every decl has a definition at the end of type checking

  

  fitzgen

  authored and

  cfallin

  committed
  0e082e8

  Copy full SHA for 0e082e8

• Add a tutorial to the README

  

  fitzgen

  authored and

  cfallin

  committed
  bffaccd

  Copy full SHA for bffaccd

• Move trie construction out to its own module

  

  fitzgen

  authored and

  cfallin

  committed
  381dada

  Copy full SHA for 381dada

• Fill out implementation overview in README

  

  fitzgen

  authored and

  cfallin

  committed
  31d1cf3

  Copy full SHA for 31d1cf3

• Report the recursive calls when an extractor is recursive

  

  fitzgen

  authored and

  cfallin

  committed
  9af23bf

  Copy full SHA for 9af23bf

• Fix a panic when checking the call graph for an extractor with type errors in its definition

  

  fitzgen

  authored and

  cfallin

  committed
  fddff6e

  Copy full SHA for fddff6e

• Allow terms to have both extractors and constructors

  Show description for 7f8cb75
  

  fitzgen

  authored and

  cfallin

  committed
  7f8cb75

  Copy full SHA for 7f8cb75

• Yield source positions from lexer that have file-relative offsets

  Show description for fe836a2
  

  fitzgen

  authored and

  cfallin

  committed
  fe836a2

  Copy full SHA for fe836a2

• Keep track of where primitives are defined for better error messages

  

  fitzgen

  authored and

  cfallin

  committed
  efe7df7

  Copy full SHA for efe7df7

• Use BTree{Map,Set} instead of Hash{Map,Set} to ensure deterministic output

  Show description for 0e02ec4
  

  fitzgen

  authored and

  cfallin

  committed
  0e02ec4

  Copy full SHA for 0e02ec4

• Do not use 1-member tuples in external constructor/extractor trait methods

  Show description for e015a49
  

  fitzgen

  authored and

  cfallin

  committed
  e015a49

  Copy full SHA for e015a49

• Allow irrefutable let patterns in the generated code

  

  fitzgen

  authored and

  cfallin

  committed
  0c69563

  Copy full SHA for 0c69563

• Emit if lets against Option<x> instead of Option<(x,)>

  

  fitzgen

  authored and

  cfallin

  committed
  7fab7c5

  Copy full SHA for 7fab7c5

• Fix allow declaration

  

  fitzgen

  authored and

  cfallin

  committed
  0411b20

  Copy full SHA for 0411b20

• Add a method to pretty-print a trie

  

  fitzgen

  authored and

  cfallin

  committed
  6c6b7a2

  Copy full SHA for 6c6b7a2

• Make sure that infallible match operations come after fallible ones

  Show description for 037db8a
  

  fitzgen

  authored and

  cfallin

  committed
  037db8a

  Copy full SHA for 037db8a

• Remove eprintln!s that shouldn't have been committed

  

  fitzgen

  authored and

  cfallin

  committed
  22e18a9

  Copy full SHA for 22e18a9

• Add better error messages for duplicate term declarations

  

  fitzgen

  authored and

  cfallin

  committed
  8f5dffa

  Copy full SHA for 8f5dffa

• Add support for hex integer literals

  

  fitzgen

  authored and

  cfallin

  committed
  bd8c7fa

  Copy full SHA for bd8c7fa

• Add myself as a second author

  

  fitzgen

  authored and

  cfallin

  committed
  e235647

  Copy full SHA for e235647

• Add Cargo.toml metadata

  

  fitzgen

  authored and

  cfallin

  committed
  4c61c96

  Copy full SHA for 4c61c96

Commits on Nov 12, 2021

• Make ISLE part of the root Cargo workspace.

  cfallin

  committed
  f227699

  Copy full SHA for f227699

Commits on Nov 15, 2021

• Remove extra, unused Cargo.lock

  fitzgen

  committed
  b6fd3d0

  Copy full SHA for b6fd3d0

• Remove old ISLE-generated file

  fitzgen

  committed
  4a34d2c

  Copy full SHA for 4a34d2c

• ISLE: update repo in Cargo.toml

  fitzgen

  committed
  f27b357

  Copy full SHA for f27b357

• ISLE: match cranelift version

  fitzgen

  committed
  6164ba3

  Copy full SHA for 6164ba3

• Clarify comment about force_graphical in miette

  fitzgen

  committed
  48ef2c0

  Copy full SHA for 48ef2c0

• Update miette graphical-forcing comment to reference upstream issue

  fitzgen

  committed
  0b1bf10

  Copy full SHA for 0b1bf10