c-api: Avoid losing error context with instance traps #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was a mistake from bytecodealliance#5149
alexcrichton
added a commit
to alexcrichton/wasmtime-go
that referenced
this pull request
Nov 8, 2022
This should fix compat with the `main` build of Wasmtime once bytecodealliance/wasmtime#5223 is merged.
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
approved these changes
Nov 8, 2022
alexcrichton
added a commit
to bytecodealliance/wasmtime-go
that referenced
this pull request
Nov 8, 2022
* Update for trap changes in Wasmtime This should fix compat with the `main` build of Wasmtime once bytecodealliance/wasmtime#5223 is merged. * Fix GC issue with frames on a trap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was a mistake from #5149